Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DSE UBI Dockerfile so tests don't fail for new functionality #356

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

emerkle826
Copy link
Contributor

@emerkle826 emerkle826 commented Aug 22, 2023

I should create a ticket.....

This fixes the issue of tests failing against DSE UBI images by building the Management API bits from the branch the tests are running, as opposed to copying them from the most recently published DSE Ubuntu image (that may not have the current branch's functionality being tested)

Fixes issue
#357

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@Miles-Garnsey Miles-Garnsey changed the base branch from master to feature/client-gen August 22, 2023 03:44
Copy link
Member

@Miles-Garnsey Miles-Garnsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the merge target over to be the integration branch. All tests (including the previously failing DSE UBI tests) now appear to pass, so I'm approving. Thanks @emerkle826.

@Miles-Garnsey Miles-Garnsey merged commit 65e197b into feature/client-gen Aug 22, 2023
92 of 95 checks passed
@Miles-Garnsey Miles-Garnsey deleted the dse-ubi-fix branch August 22, 2023 03:47
@emerkle826 emerkle826 linked an issue Aug 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UBI tests so they are not dependent on other tests in same PR
2 participants