Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getClusterName endpoint, add currentStreams DTO for reloadLocalSchema #346

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Add getClusterName endpoint, add currentStreams DTO for reloadLocalSchema #346

merged 2 commits into from
Aug 18, 2023

Conversation

emerkle826
Copy link
Contributor

Fixes #345

@emerkle826 emerkle826 changed the base branch from master to feature/client-gen August 17, 2023 01:30
@emerkle826
Copy link
Contributor Author

@Miles-Garnsey Note the test failures here should only be for DSE 6.8 with a UBI based image. The reason is the UBI Dockerfile for DSE 6.8 actually pulls from the DSE 6.8 Ubuntu based image. Because this PR adds a new endpoint and a test for it, the UBI tests fail since the Ubuntu based images haven't been published yet (this PR hasn't been merged or released which would publish the image), so the image that the UBI image is based on is the most recently released Ubuntu image, that doesn't have the endpoint yet.

Miles-Garnsey
Miles-Garnsey requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@Miles-Garnsey Miles-Garnsey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One or two issues, and a few questions. If I'm reading this right you're adding getClusterName and adding a streamingInfo model class which gets returned from reloadLocalSchema?

management-api-server/src/main/java/com/datastax/mgmtapi/resources/MetadataResources.java Outdated Show resolved Hide resolved
management-api-server/src/main/java/com/datastax/mgmtapi/resources/models/BaseEntity.java Show resolved Hide resolved
management-api-server/src/main/java/com/datastax/mgmtapi/resources/models/EndpointStates.java Show resolved Hide resolved
management-api-server/src/main/java/com/datastax/mgmtapi/resources/models/BaseEntity.java Show resolved Hide resolved
management-api-server/src/test/java/com/datastax/mgmtapi/MetadataResourcesTest.java Outdated Show resolved Hide resolved
management-api-server/src/main/java/com/datastax/mgmtapi/resources/MetadataResources.java Outdated Show resolved Hide resolved
management-api-server/src/main/java/com/datastax/mgmtapi/resources/NodeOpsResources.java Show resolved Hide resolved
@Miles-Garnsey Miles-Garnsey changed the title Add getClusterName endpoint, add currentStreams DTO Add getClusterName endpoint, add currentStreams DTO for reloadLocalSchema Aug 17, 2023
@emerkle826
Copy link
Contributor Author

One or two issues, and a few questions. If I'm reading this right you're adding getClusterName and adding a streamingInfo model class which gets returned from reloadLocalSchema?

Yes, adding getClusterName and a DTO for streaming info. However, the DTO is only returned from getStreamInfo(), not reloadLocalSchema

Miles-Garnsey
Miles-Garnsey approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@Miles-Garnsey Miles-Garnsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All feedback addressed, still one failing UBI test but this can be resolved prior to merge to master.

Approving merge to the integration branch now.

@emerkle826 emerkle826 merged commit f56e47c into feature/client-gen Aug 18, 2023
46 of 47 checks passed
@emerkle826 emerkle826 deleted the client-gen-clusterName branch August 18, 2023 01:10
emerkle826 added a commit that referenced this pull request Sep 15, 2023
@emerkle826
Add getClusterName endpoint, add currentStreams DTO for reloadLocalSc…
09f03f1 
…hema (#346)

* Add currentStreams DTO
* add cluster name into endpoints response
emerkle826 added a commit that referenced this pull request Sep 15, 2023
@emerkle826
Add getClusterName endpoint, add currentStreams DTO for reloadLocalSc…
3a66619 
…hema (#346)

* Add currentStreams DTO
* add cluster name into endpoints response
emerkle826 added a commit that referenced this pull request Oct 12, 2023
@emerkle826
Add getClusterName endpoint, add currentStreams DTO for reloadLocalSc…
3f86690 
…hema (#346)

* Add currentStreams DTO
* add cluster name into endpoints response
emerkle826 added a commit that referenced this pull request Oct 12, 2023
@emerkle826
Add getClusterName endpoint, add currentStreams DTO for reloadLocalSc…
ffad3dd 
…hema (#346)

* Add currentStreams DTO
* add cluster name into endpoints response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burmanm burmanm burmanm left review comments

@adejanovski adejanovski adejanovski left review comments

@Miles-Garnsey Miles-Garnsey Miles-Garnsey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement host related methods
4 participants
@emerkle826 @burmanm @adejanovski @Miles-Garnsey