Skip OpenAPI generation in Dockerfiles #334
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Closed
Miles-Garnsey
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
My understanding of this PR is that DskipOpenApi just skips the creation of the OpenAPI spec, which is not required to build the Cassandra/DSE images (which include the management API) in any event.
On that basis this is approved, please let me know if I'm misinterpreting the purpose of this PR.
That is correct. Trying to keep the scope/concern of each of these PRs limited so that it's not so much to review in one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these were left out in the initial OpenAPI client publishing PR