Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set jmxremote.authenticate system property by default #926

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olim7t
Copy link
Contributor

@olim7t olim7t commented Mar 24, 2023

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.5% 5.5% Duplication

@adejanovski
Copy link
Contributor

By making this change we're changing our defaults. I think we should allow to opt out of having jmx auth enabled instead of changing the default, which will trigger a rolling restart upon upgrade ;)

@olim7t
Copy link
Contributor Author

olim7t commented Mar 24, 2023

By making this change we're changing our defaults. I think we should allow to opt out of having jmx auth enabled instead of changing the default, which will trigger a rolling restart upon upgrade ;)

I don't know, that sounds overkill for such a small change.

Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olim7t, let's move forward with this, even if we're changing the defaults.
Three things:

  • Could you add a changelog entry?
  • The unit tests are failing it seems, we'd need to rerun them to see what's going on.
  • The PR is still in draft mode.

@adejanovski
Copy link
Contributor

@olim7t, should we close this and fully remove changes we make on the JMX config now that Reaper moved to using the management api?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants