Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link state enable on test #821

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Dec 23, 2024

if we run on a system where the PF is not connected to the network we can still use it for tests but we need the link state to not be auto.

@SchSeba SchSeba requested a review from zeeke December 23, 2024 18:35
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Dec 23, 2024

@adrianchiris @zeeke please take a look quick fix for our internal CI system when the nics are not all connected to the network

@coveralls
Copy link

coveralls commented Dec 23, 2024

Pull Request Test Coverage Report for Build 12478723972

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 47.271%

Files with Coverage Reduction New Missed Lines %
controllers/drain_controller_helper.go 1 63.59%
controllers/helper.go 1 69.66%
Totals Coverage Status
Change from base Build 12432456295: 0.05%
Covered Lines: 7205
Relevant Lines: 15242

💛 - Coveralls

if we run on a system where the PF is not connected to the network
we can still use it for tests but we need the link state to not be
auto.

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba SchSeba force-pushed the fix_mtu_disconnected_test branch from 6994d98 to d7d2e57 Compare December 24, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants