Skip kernel parameters configuration for Ubuntu #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 12466349107Details
💛 - Coveralls |
| if [[ $args != *${t}* ]];then | ||
| if chroot /host/ rpm-ostree kargs | grep -vq ${t}; then | ||
| chroot /host/ rpm-ostree kargs --append ${t} > /dev/null 2>&1 | ||
| IS_OS_UBUNTU=true; [[ "$(chroot /host/ grep -i ubuntu /etc/os-release -c)" == "0" ]] && IS_OS_UBUNTU=false |
There was a problem hiding this comment.
can you add a comment that applying kargs for ubuntu is not supported and currently we do a no-op ?
adrianchiris
approved these changes
Dec 23, 2024
It's enouph to configure ib_core module in /etc/moprobe.d/ for Ubuntu OS to change RDMA subsystem mode. Also this commit add OS check into kargs.sh error because 'grubby' isn't available in official Ubuntu repositories. Kernel param configuration support in Ubuntu should be implemented in a separate commit. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
SchSeba
reviewed
Dec 25, 2024
There was a problem hiding this comment.
just a small simplification to the script and also please add a note/section in the readme that for ubuntu systems the user must configure the kernel args manually base on the list we have in the consts
KernelArgPciRealloc = "pci=realloc"
KernelArgIntelIommu = "intel_iommu=on"
KernelArgIommuPt = "iommu=pt"
KernelArgIommuPassthrough = "iommu.passthrough=1"
KernelArgRdmaShared = "ib_core.netns_mode=1"
KernelArgRdmaExclusive = "ib_core.netns_mode=0"
| IS_OS_UBUNTU=true; [[ "$(chroot /host/ grep -i ubuntu /etc/os-release -c)" == "0" ]] && IS_OS_UBUNTU=false | ||
|
|
||
| # Kernerl args comfiguration isn't supported for Ubuntu now, so we shouldn't do anything here | ||
| if ! ${IS_OS_UBUNTU} ; then |
There was a problem hiding this comment.
Hi let's make this one simpler, please.
can you do something like
if ${IS_OS_UBUNTU} ; then
echo 0
exit 0
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's enouph to configure ib_core module in /etc/moprobe.d/ for Ubuntu OS to change RDMA subsystem mode.
Also this commit fixes kargs.sh error because 'grubby' isn't available in official Ubuntu repositories.