Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Makefile #41

Merged
merged 1 commit into from
Sep 4, 2024
Merged

improve Makefile #41

merged 1 commit into from
Sep 4, 2024

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Aug 28, 2024

  • switch to the right image registry
  • allow to add golang flags

Eoghan1232
Eoghan1232 reviewed Aug 28, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
Eoghan1232
Eoghan1232 reviewed Aug 28, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@SchSeba SchSeba force-pushed the allow_golang_flags_config branch from b533c51 to c459cf4 Compare August 28, 2024 14:12
Eoghan1232
Eoghan1232 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

adrianchiris
adrianchiris reviewed Sep 3, 2024
View reviewed changes
Makefile Outdated
GO = go
GO_BUILD_OPTS ?=CGO_ENABLED=0
GO_LDFLAGS ?= -s -w
GO_FLAGS ?= -buildmode=pie
Copy link
Contributor

@adrianchiris adrianchiris Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need this ? we dont do it in other repos ? the -buildmode=pie that is

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a copy paste :P

but sure let me remove it

adrianchiris
adrianchiris approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one minor nit

@SchSeba
improve Makefile
4268a38 
* switch to the right image registry
* allow to add golang flags

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba SchSeba force-pushed the allow_golang_flags_config branch from c459cf4 to 4268a38 Compare September 4, 2024 07:05
@SchSeba
Copy link
Collaborator Author

SchSeba commented Sep 4, 2024

Thanks folks!

merging

@SchSeba SchSeba merged commit 0f6a784 into k8snetworkplumbingwg:master Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eoghan1232 Eoghan1232 Eoghan1232 approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SchSeba @adrianchiris @Eoghan1232