Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override go tags in build #580

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

bn222
Copy link
Contributor

@bn222 bn222 commented Jul 25, 2024

No description provided.

@bn222
Copy link
Contributor Author

bn222 commented Jul 25, 2024

@adrianchiris your previous PR didn't address this yet.

@SchSeba also ptal here and lgtm. We need to use this downstream.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10093735052

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.187%

Totals Coverage Status
Change from base Build 10089765557: 0.0%
Covered Lines: 2115
Relevant Lines: 2813

💛 - Coveralls

@vrindle
Copy link

vrindle commented Jul 25, 2024

LGTM

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba
Copy link
Collaborator

SchSeba commented Jul 25, 2024

cc @adrianchiris
please take a look

@adrianchiris adrianchiris merged commit 96a258e into k8snetworkplumbingwg:master Jul 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants