bump dependencies #578
Merged
bump dependencies #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adrianchiris
commented
Jul 24, 2024
•
adrianchiris
commented
- bump dependencies like in Bump the gomod-dependencies group across 1 directory with 6 updates #577
- fix lint issues by removing the use of grpc.WithBlock() dial option
Pull Request Test Coverage Report for Build 10092515578Details
💛 - Coveralls |
adrianchiris
force-pushed
the
bump-dependencies
branch
from
7dae6e4
to
a74e792
Compare
|
@Eoghan1232 PTAL if you got time :) |
SchSeba
reviewed
Jul 25, 2024
pkg/resources/server.go
Outdated
| @@ -265,38 +264,14 @@ func (rs *resourceServer) Start() error { | |||
| } | |||
| pluginapi.RegisterDevicePluginServer(rs.grpcServer, rs) | |||
|
|
|||
| // start serving from grpcServeer | |||
There was a problem hiding this comment.
thx, some of my keyboard switches are double typing :\
| go func() { | ||
| err := rs.grpcServer.Serve(lis) | ||
| if err != nil { | ||
| glog.Errorf("serving incoming requests failed: %s", err.Error()) | ||
| } | ||
| }() | ||
|
|
||
| conn, err := grpc.NewClient( |
There was a problem hiding this comment.
we don't want to wait for the server to start?
There was a problem hiding this comment.
we dont. thats an anti-pattern, see commit msg with relevant link.
Signed-off-by: adrianc <[email protected]>
WithBlock() dial option is deprecated, recommendation is to let the caller handle failures with retry see[1] this change is needed to sort out lint issues in ci. [1] https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md#especially-bad-using-deprecated-dialoptions Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
bump-dependencies
branch
from
a74e792
to
958ed1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.