remove grpc deprication functions #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Sch <[email protected]>
Pull Request Test Coverage Report for Build 8648539048Details
💛 - Coveralls |
SchSeba
commented
Apr 13, 2024
| @@ -271,17 +271,31 @@ func (rs *resourceServer) Start() error { | |||
| glog.Errorf("serving incoming requests failed: %s", err.Error()) | |||
| } | |||
| }() | |||
| // Wait for server to start by launching a blocking connection | |||
| ctx, _ := context.WithTimeout(context.TODO(), serverStartTimeout) | |||
| conn, err := grpc.DialContext( | |||
There was a problem hiding this comment.
new version of the grpc doesn't make a connection when creating the client so to maintain the same functionally here we need to create the client and run a connect function that is a blocking one
jaypipes
approved these changes
Apr 16, 2024
e0ne
approved these changes
Apr 25, 2024
|
Thanks! merging this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.