Lock file integration test #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: Andrea Panattoni <[email protected]>
Having a test suite that covers the code from an out-of-process perspective helps in testing specific scenarios, e.g. when the concurrency of multiple program instances occurs. Also, using test doubles instead of real SR-IOV capable NICs makes tests fast and portable, in a way that can be run at every commit. Add a test suite that invokes a system-mocked version of the sriov CNI binary, in which the `/sys` filesystem content is defined at code, and the network interfaces are of type dummy. Add `test-integration` make target to invoke the test suite. Signed-off-by: Andrea Panattoni <[email protected]>
When running on heavy a load, sriov-cni might be invoked multiple times by the kubelet or the container runtime. In these situations, it might happen that a `cmdAdd` or a `cmdDel` run on the same device that is still handled by a `cmdDel` instance (e.g. when the IPAM plugin takes a long time to finish). This commit adds a Lock mechanism around the `/var/lib/cni/sriov/<PCI>` address, to avoid two or more instances handling the same the device. The lock is based on `flock` [1] using the `O_CLOEXEC` flag, which garantees that the lock is released when the process finishes. [1] https://linux.die.net/man/2/flock Signed-off-by: Andrea Panattoni <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644) | ||
| if err != nil { | ||
| log.Println(err) | ||
| return |
Check warning
Code scanning / CodeQL
Writable file handle closed without error handling Warning test
Pull Request Test Coverage Report for Build 12809721778Details
💛 - Coveralls |
Depends on: - k8snetworkplumbingwg#313 Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
us/lock-file-integration-test
branch
from
80f1d8d to
9932e03
Compare
|
/hold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests for
This PR is not part of #313 because it depends on
which I prefer to keep aside from #313 review.