Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass through the pod annotations when multus receives them #1204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toelke
Copy link

@toelke toelke commented Jan 8, 2024

See kubernetes/kubernetes#69882 (comment) and #1116

Passing the annotations seems not to be a standardized behaviour, but it is very useful nontheless.

See https://github.com/kubernetes/kubernetes/issues/69882\#issuecomment-1509077177

Passing the annotations seems not to be a standardized behaviour, but it is very useful nontheless.

Signed-off-by: Philipp Riederer <[email protected]>
@s1061123
Copy link
Member

I'm not clear that io.kubernetes.cri.pod-annotations comes from and use-case yet. Could you please clarify that, including why the annotation, io.kubernetes.cri.pod-annotations, should be default (to all platform).

@toelke
Copy link
Author

toelke commented Jan 19, 2024

This comment is a good summary.

My use case is that a custom CNI plugin needs some extra information to configure the networking of a Pod that I would like to pass as an annotation on the Pod; containerd can already be configured to pass this annotation to CNI plugins, this patch enables multus to receive it.

@dougbtv
Copy link
Member

dougbtv commented Feb 1, 2024

Tomo's looking into the possibility of checking this out with capability args in the meanwhile, and we'll circle back to it to make sure it's necessary.

@aojea
Copy link
Contributor

aojea commented Feb 21, 2024

Tomo's looking into the possibility of checking this out with capability args in the meanwhile, and we'll circle back to it to make sure it's necessary.

@dougbtv @s1061123 I think that this refers to the fact that you don't have to go to the apiserver to fetch the labels and the annotations of the pod if you set this option in containerd and crio kubernetes/kubernetes#69882 (comment), as those values will be available in the CNI ADD request
@MikeZappa87

Basically you can save this API call and get it from the capabilities

func GetPodNetwork(pod *v1.Pod) ([]*types.NetworkSelectionElement, error) {
logging.Debugf("GetPodNetwork: %v", pod)
netAnnot := pod.Annotations[networkAttachmentAnnot]
defaultNamespace := pod.ObjectMeta.Namespace
if len(netAnnot) == 0 {
return nil, &NoK8sNetworkError{"no kubernetes network found"}
}
networks, err := parsePodNetworkAnnotation(netAnnot, defaultNamespace)
if err != nil {
return nil, err
}
return networks, nil

@AJMansfield
Copy link

This would be a useful feature for my own use-case -- to pass node affinity/taint information concerning particular network attachments onto pods that use them.

@bgaussen
Copy link

Hi, this feature would help our CNI to get some pod annotations directly and avoid implementing token management for it to access api-server...

Copy link

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 26, 2024
@toelke
Copy link
Author

toelke commented Sep 30, 2024

I still think this is useful.

@toelke
Copy link
Author

toelke commented Sep 30, 2024

/remove-lifecycle stale

@github-actions github-actions bot removed the Stale label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants