change EndPort type to *int32 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1061123 could you please take a look? |
s1061123
requested changes
Feb 28, 2024
|
Hi @l8huang, thank you so much for the PR. Could you please take a look into my comment? |
|
Hi @s1061123 , thanks for looking at this PR, your comment addressed, could you please take a look? |
|
@s1061123 please kindly let know if it's okay to you? Thanks. |
|
@l8huang sorry for the late reply. It looks good to me, so after fixing CI, I will merge that. |
This change is for aligning with NetworkPolicyPort, this could make the conversion from MultiNetworkPolicy to NetworkPolicyPort easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is for aligning type with NetworkPolicyPort, this could make the conversion from MultiNetworkPolicy to NetworkPolicyPort easier.