Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: examples + pod unscheduable w/node #1356

Closed
wants to merge 0 commits into from
Closed

feat: examples + pod unscheduable w/node #1356

wants to merge 0 commits into from

Conversation

AlexsJones
Copy link
Member

@AlexsJones AlexsJones commented Jan 3, 2025 •
edited
Loading

This will allow for detection of dead/missing nodes, also providing some examples of broken manifests users can try out

📑 Description

✅ Checks

  • [x ] My pull request adheres to the code style of this project
  • [x ] My code requires changes to the documentation
  • [x ] I have updated the documentation as required
  • [x ] All the tests have passed

ℹ Additional Information

@AlexsJones AlexsJones requested review from a team as code owners January 3, 2025 17:21
matthisholleville
matthisholleville approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@matthisholleville matthisholleville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Shouldn't we add PR Description ?

@AlexsJones
Copy link
Member Author

?

Yes, good spot - done! Thanks

@AlexsJones AlexsJones closed this Jan 12, 2025
@AlexsJones AlexsJones deleted the feat/examples branch January 12, 2025 16:51
@AlexsJones AlexsJones restored the feat/examples branch January 12, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthisholleville matthisholleville matthisholleville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexsJones @matthisholleville