Fix default channel annotations #5978
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunya-ch
approved these changes
Apr 8, 2025
mporrato
force-pushed
the
multi-nic-cni-fix
branch
from
cb3e701 to
642fbab
Compare
Signed-off-by: Maurizio Porrato <[email protected]>
mporrato
force-pushed
the
multi-nic-cni-fix
branch
from
642fbab to
891fd57
Compare
Signed-off-by: Maurizio Porrato <[email protected]>
Signed-off-by: Maurizio Porrato <[email protected]>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @minmzzhang @sunya-ch , we noticed there is an issue with the default channel annotation in some bundles: it looks like there must be at least one bundle with the default channel annotation in each channel and in this operator, all the bundles in channels alpha, beta, alpha-1.2 and stable-1.2 are missing such annotation.
This is causing silent failures in the release workflow resulting in the bundles not being published.
In this PR I'm adding the annotation to the first bundle of each channel and this should hopefully fix the issue.