Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator [N] [CI] debezium-operator (2.4.0) #3320

Merged

Conversation

jcechace
Copy link
Contributor

@jcechace jcechace commented Oct 4, 2023

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

No with the entire OH structure. The link seems absolete (for one it uses the outdate database catalog format).

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo
    Not realy sure what that is.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

@github-actions github-actions bot changed the title operator debezium-operator (2.4.0) operator [N] [CI] debezium-operator (2.4.0) Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Dear @jcechace,
Some errors and/or warnings were found while doing the check of your operator (debezium-operator/2.4.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
🐛 Value : (debezium-operator.v2.4.0) csv.Spec.Links url debezium.zulipchat.com is invalid: parse "debezium.zulipchat.com": invalid URI for request
⚠️ Value : (debezium-operator.v2.4.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value debezium-operator.v2.4.0: unable to find the resource requests for the container: (debezium-operator). It is recommended to ensure the resource request for CPU and Memory. Be aware that for some clusters configurations it is required to specify requests or limits for those values. Otherwise, the system or quota may reject Pod creation. More info: https://master.sdk.operatorframework.io/docs/best-practices/managing-resources/
⚠️ Value debezium-operator.v2.4.0: owned CRD "debeziumservers.debezium.io" has an empty description

@jcechace jcechace force-pushed the debezium-operator.v2.4.0 branch from ddd9db9 to ff3a79b Compare October 4, 2023 19:57
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@mporrato
Copy link
Collaborator

mporrato commented Oct 5, 2023

@jcechace can you add the .metadata.annotations.repository field? Other than that, LGTM.

@jcechace jcechace force-pushed the debezium-operator.v2.4.0 branch from ff3a79b to eda40f5 Compare October 5, 2023 11:26
@jcechace
Copy link
Contributor Author

jcechace commented Oct 5, 2023

@mporrato done

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation framework-automation merged commit 04f46ce into k8s-operatorhub:main Oct 5, 2023
@jcechace
Copy link
Contributor Author

jcechace commented Oct 5, 2023

@mporrato One question. Since this is our first submission, I noticed that we are still missing some metadata for CRDs. Is it possible to add those and submit the changes? Thanks for the answer.

@mporrato
Copy link
Collaborator

mporrato commented Oct 6, 2023

@jcechace I see you already submitted a new pr and it got auto-merged, so I think you found the answer on your own :).
Let me know if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants