Increase number of renovate bot PRs #1615
Conversation
abaguas
requested review from
donovanmuller,
k0da,
kuritka,
ytsarev and
jkremser
as code owners
Since k8gb-io#1610 was merged the number of PRs created by renovate increased, as bumps of libraries on version 0.x are handled in a dedicated PR. The maximum number of concurrent PRs is 5 which results in rate-limiting: k8gb-io#1048. The proposal is to increase it to 15 so that we can see and tackle the PRs containing potential breaking changes. In addition, the `update all non-major dependencies` group should very rarely contain breaking changes (k8gb-io#1052) so I proposal to turn on automerge (if the pipeline is green ofc). This should save the maintainers some precious minutes. Signed-off-by: abaguas <[email protected]>
abaguas
force-pushed
the
renovate/automerge
branch
from
ba0c75e
to
88b1d41
Compare
|
I understand that passing tests give us a certain kind of security I'm just not sure with dependencies mentioned below (at least the first three or four are better to bump at once). For the rest of dependencies in main |
The auto-merge would affect only the |
|
correct, thx. Than I'm fine with that. |
|
current controller-runtime is |
@kuritka If you think it would make our life easier we can enable separateMultipleMinor. This would create one PR per minor bump and would all us to tackle the breaking changes one minor a time, instead of going directly from |
|
I would be happy to merge this one already, we can check further improvements later if necessary. |
In k8gb-io#1615 auto merge was enabled for [all non-major dependencies](k8gb-io#1052 (comment)). However, the PR cannot be merged without an approving review. The missing piece would be the following app: https://github.com/apps/renovate-approve. It would approve all PRs created by the renovate bot that have auto merge enabled. Unfortunately, it cannot do it for projects that have CODEOWNERS setup, which is our case: > Important note: Due to a GitHub limitation, it is not possible to assign any app like this one as a CODEOWNER, so unfortunately this bot won't work that way if you have CODEOWNERS set up. Since auto merge does not work this PR removes the configuration to avoid any confusion Signed-off-by: abaguas <[email protected]>
In #1615 auto merge was enabled for [all non-major dependencies](#1052 (comment)). However, the PR cannot be merged without an approving review. The missing piece would be the following app: https://github.com/apps/renovate-approve. It would approve all PRs created by the renovate bot that have auto merge enabled. Unfortunately, it cannot do it for projects that have CODEOWNERS setup, which is our case: > Important note: Due to a GitHub limitation, it is not possible to assign any app like this one as a CODEOWNER, so unfortunately this bot won't work that way if you have CODEOWNERS set up. Since auto merge does not work this PR removes the configuration to avoid any confusion Signed-off-by: abaguas <[email protected]>
Since #1610 was merged the number of PRs created by renovate increased, as bumps of libraries on version 0.x are handled in a dedicated PR. The maximum number of concurrent PRs is 5 which results in rate-limiting: #1048. The proposal is to increase it to 15 so that we can see and tackle the PRs containing potential breaking changes.
In addition, the
update all non-major dependenciesgroup should very rarely contain breaking changes (#1052) so I propose to turn on automerge (if the pipeline is green ofc). This should save the maintainers some precious minutes.