#30 PersistentKeepAlive should be specified in the config file of the host which is behind NAT. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the config files.
|
I agree. PersistantKeepalive is basically irrelevant if you don't do #32, but this is definitely the right way to think about the option. If keepalive is set, it should apply to all peers in a given config. |
k4yt3x
reviewed
Sep 6, 2023
k4yt3x
approved these changes
Sep 6, 2023
|
I've done some tests based on the code you've submitted and it appears to work great. Thanks for the PR and sorry for the slow response time, got too many things going on right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration :)
Closes #30
I would like to do some refactoring after this, but I wanted to check what you think of my solution, first.