Merge pull request #190 from jkowalleck/master

slight improv in ImageCrawler deduplication checks
k4cg · Jan 28, 2020 · 3913b78 · 3913b78
2 parents c343f60 + fd000f5
commit 3913b78
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/nichtparasoup/core/__init__.py b/nichtparasoup/core/__init__.py
@@ -142,7 +142,7 @@ def _add_image_to_blacklist(self, image: Image) -> None:
             self.blacklist.add(image.uri)
 
     def has_imagecrawler(self, imagecrawler: BaseImageCrawler) -> bool:
-        return imagecrawler in [crawler.imagecrawler for crawler in self.crawlers]
+        return imagecrawler in (crawler.imagecrawler for crawler in self.crawlers)
 
     def add_imagecrawler(self, imagecrawler: BaseImageCrawler, weight: _CrawlerWeight) -> None:
         self.crawlers.append(Crawler(

diff --git a/nichtparasoup/testing/config.py b/nichtparasoup/testing/config.py
@@ -13,7 +13,7 @@ class ConfigFileTest(TestCase):
     def validate(self, file: str) -> None:
         config = parse_yaml_file(file)
         self.assertIsInstance(config, dict)
-        imagecrawlers = []  # type: List[BaseImageCrawler]
+        imagecrawlers = list()  # type: List[BaseImageCrawler]
         for crawler_config in config['crawlers']:
             imagecrawler = get_imagecrawler(crawler_config)
             self.assertNotIn(imagecrawler, imagecrawlers, msg='Duplicate ImageCrawler')