Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add etcd snapshot metrics:
Note that the total number of ETCDSnapshotFile resources present does NOT have a metric here - that can already be queried from apiserver storage object count metrics:
apiserver_storage_objects{resource="etcdsnapshotfiles.k3s.cattle.io"} 1
Types of Changes
enhancement
Verification
Check metrics on etcd node:
Note that there will be no s3 metrics if s3 is not enabled.
Testing
Linked Issues
User-Facing Change
Further Comments