Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #issue 67 - invalide tv_umur_id if no periode_isolation #68

Merged
merged 2 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/3.2.1_mur.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export default function calc_mur(mur, zc, pc_id, ej) {
break;
case "année d'isolation différente de l'année de construction saisie justifiée (table forfaitaire)": {
calc_umur0(di, de, du);
const pi_id = requestInputID(de, du, 'periode_isolation');
const pi_id = requestInputID(de, du, 'periode_isolation') || pc_id;
tv_umur(di, de, du, pi_id, zc, ej);
di.umur = Math.min(di.umur, di.umur0);
break;
Expand Down
1 change: 0 additions & 1 deletion src/3.2.3_plancher_haut.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ export default function calc_ph(ph, zc, pc_id, ej) {
}
}
calc_uph0(di, de, du);
const tv_uph_avant = de.tv_uph_id;
tv_uph(di, de, du, pi_id, zc, ej);
di.uph = Math.min(di.uph, di.uph0);
break;
Expand Down
10 changes: 10 additions & 0 deletions test/open3cl_tv.spec.js → test/open3cl_misc.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,14 @@ describe('Open3cl misc unit tests', () => {

expect(output.logement.sortie.qualite_isolation.qualite_isol_plancher_bas).toBe(1);
});

it('should have a valid tv_umur_if if no periode_isolation', () => {
const input = structuredClone(getAdemeFileJson('2421E0125604W'));
const inputTvMurId = input.logement.enveloppe.mur_collection.mur[0].donnee_entree.tv_umur_id;

const output = calcul_3cl(input);

const outputTvMurId = output.logement.enveloppe.mur_collection.mur[0].donnee_entree.tv_umur_id;
expect(inputTvMurId).toBe(outputTvMurId);
});
});