Allow template to be a whole directory #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilder
requested changes
Sep 26, 2016
|
@jwilder just updated the README. |
|
@jwilder is there still something missing for this PR to be merged? |
|
I am also loking for this feature simply because i have sites_enabled in my nginx, and everyone of them i need to transform into a template. Glad there is PR already. |
|
@jwilder would love to get some feedback. |
|
@jwilder I have updated the README, as you asked me to do. how do you want me to proceed? |
jwilder
requested changes
Dec 1, 2016
| log.Fatalf("unable to stat %s, error: %s", template, err) | ||
| } | ||
| if fi.IsDir() { | ||
| if dest != "" { |
There was a problem hiding this comment.
Could you move this whole block L241-L262 to a separate func like generateDir?
|
|
||
| for _, file := range files { | ||
| if dest == "" { | ||
| generateFile(template+string(os.PathSeparator)+file.Name(), "") |
There was a problem hiding this comment.
You can use filepath.Join(template, file.Name) here
| if dest == "" { | ||
| generateFile(template+string(os.PathSeparator)+file.Name(), "") | ||
| } else { | ||
| generateFile(template+string(os.PathSeparator)+file.Name(), dest+string(os.PathSeparator)+file.Name()) |
There was a problem hiding this comment.
Ditto: file path.Join(...) for these.
Use filepath.Join Implement review feedback from jwilder
|
@jwilder just implemented your suggestions. |
|
Thanks @breml! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use-case: process complete conf.d directories without the need to list every file separately.