Get rid of custom Setup.hs files #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsenag
referenced
this pull request
Jul 9, 2019
This is based on the change in jgm/zip-archive#22 which was solving a similar issue. If you want, I'm happy to apply this change to gitlib-cmdline as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here, custom Setup.hs files cause problems for cabal v2-build.
The build-tools stanzas are also deprecated but don't seem to be causing any problems right now, so I've left them alone.
This partially reverts commit 76d8be5
and commit bd26e03.
("Make git a test dependency of gitlib-cmdline."
and "Make git a test dependency of hlibgit2.")
The downside of this change is that if git is missing it will no
longer be flagged by cabal.