add vagrant playground #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for breaking this out, it should be really helpful in a bunch of ways |
jwhited
reviewed
Jan 19, 2021
| Vagrant.configure("2") do |config| | ||
|
|
||
| config.trigger.before :up do |trigger| | ||
| trigger.run = {inline: "cp -uvf ../../../../../bin/coredns ../../../../../bin/wgsd-client ."} |
There was a problem hiding this comment.
on Darwin I get this error:
% vagrant up
Bringing machine 'registry' up with 'virtualbox' provider...
Bringing machine 'client-1' up with 'virtualbox' provider...
Bringing machine 'client-2' up with 'virtualbox' provider...
Bringing machine 'client-3' up with 'virtualbox' provider...
Bringing machine 'client-4' up with 'virtualbox' provider...
==> registry: Running action triggers before up ...
==> registry: Running trigger...
registry: Running local: Inline script
registry: cp -uvf ../../../../../bin/coredns ../../../../../bin/wgsd-client .
registry: /bin/cp: illegal option -- u
I imagine this won't work unless the host is a Linux kernel. Instead of copying binaries from the host, can we build within setup.sh so that the Vagrantfile is portable across host OS? That also removes any cross compilation confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce vagrant environment #20