Skip to content

Commit

Permalink
Fix names, update release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
jviau committed Jul 23, 2020
1 parent 63de36a commit c4cd4a8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
5 changes: 2 additions & 3 deletions releasenotes.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
- Moves `TaskHubOptions` to `DurableTask.Hosting.Options` namespace.
- Adds `IncludeDetails` flags configuration.
- Add error message to `WrapperObjectManager.Add`
- Add assembly scanning extensions for including orchestrations and activities.
- Add `TaskAliasAttribute`
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

<ItemGroup>
<None Update="Properties\Strings.Designer.tt">
<CustomToolNamespace></CustomToolNamespace>
<Generator>TextTemplatingFileGenerator</Generator>
<LastGenOutput>Strings.Designer.cs</LastGenOutput>
</None>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public static ITaskHubWorkerBuilder AddActivity<TActivity>(
/// <param name="assembly">The assembly to discover types from. Not null.</param>
/// <param name="includePrivate">True to include private/protected/internal types, false for public only.</param>
/// <returns>The original builder with activity added.</returns>
public static ITaskHubWorkerBuilder AddActivitesFromAssembly(
public static ITaskHubWorkerBuilder AddActivitiesFromAssembly(
this ITaskHubWorkerBuilder builder, Assembly assembly, bool includePrivate = false)
{
Check.NotNull(builder, nameof(builder));
Expand All @@ -133,9 +133,9 @@ public static ITaskHubWorkerBuilder AddActivitesFromAssembly(
/// <param name="includePrivate">True to also include private/protected/internal types, false for public only.</param>
/// <typeparam name="T">The type contained in the assembly to discover types from.</typeparam>
/// <returns>The original builder with activity added.</returns>
public static ITaskHubWorkerBuilder AddActivitesFromAssembly<T>(
public static ITaskHubWorkerBuilder AddActivitiesFromAssembly<T>(
this ITaskHubWorkerBuilder builder, bool includePrivate = false)
=> AddActivitesFromAssembly(builder, typeof(T).Assembly, includePrivate);
=> AddActivitiesFromAssembly(builder, typeof(T).Assembly, includePrivate);

/// <summary>
/// Adds the provided activity middleware to the builder.
Expand Down

0 comments on commit c4cd4a8

Please sign in to comment.