-
Notifications
You must be signed in to change notification settings - Fork 15
Add code-lens to run pipeline #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2401fe0
Add code lense to run pipeline
georg-schwarz b9b9629
Make interpreter work with absolute paths
georg-schwarz f3eebc4
Remove console log in jayvee-code-lens-provider
georg-schwarz 10ad9a2
Remove unused import in tests
georg-schwarz 292030f
Run selected pipeline instead of all pipelines on code lens
georg-schwarz 3c65a2f
Fix copyright year
georg-schwarz 46abadd
rename guard function parameters
georg-schwarz 3a61993
Add a second run code lens for running with debug output
georg-schwarz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
// SPDX-FileCopyrightText: 2024 Friedrich-Alexander-Universitat Erlangen-Nurnberg | ||
// | ||
// SPDX-License-Identifier: AGPL-3.0-only | ||
|
||
// eslint-disable-next-line unicorn/prefer-node-protocol | ||
import { strict as assert } from 'assert'; | ||
import { exec } from 'node:child_process'; | ||
import { readFileSync } from 'node:fs'; | ||
import path from 'node:path'; | ||
|
||
import { isRunJayveeCodeLensPayload } from '@jvalue/jayvee-language-server'; | ||
import { type ExtensionContext, window } from 'vscode'; | ||
|
||
export async function runJayveeCommand( | ||
payload: unknown, | ||
enableDebugOutput: boolean, | ||
context: ExtensionContext, | ||
) { | ||
try { | ||
await throwOnMismatchingJayveeVersion(context); | ||
} catch (e: unknown) { | ||
const errorMsg = e instanceof Error ? e.message : 'unknown error'; | ||
await window.showErrorMessage(`Error executing jv: ${errorMsg}`); | ||
} | ||
|
||
assert( | ||
isRunJayveeCodeLensPayload(payload), | ||
`Payload ${JSON.stringify( | ||
payload, | ||
)} is not a valid RunJayveeCodeLensPayload`, | ||
); | ||
const filePath = payload.filePath; | ||
|
||
const shell = window.createTerminal('Run Jayvee'); | ||
shell.sendText( | ||
`jv ${filePath} --pipeline ${payload.pipelineName}${ | ||
enableDebugOutput ? ' --debug --debug-granularity peek' : '' | ||
}`, | ||
); | ||
shell.show(); | ||
} | ||
|
||
function throwOnMismatchingJayveeVersion( | ||
context: ExtensionContext, | ||
): Promise<void> { | ||
const command = 'jv --version'; | ||
const requiredVersion = getExtensionVersion(context); | ||
|
||
return new Promise((resolve, reject) => { | ||
exec(command, (error, stdout) => { | ||
if (error) { | ||
return reject(error); | ||
} | ||
|
||
const installedVersion = stdout.trim(); | ||
if (installedVersion !== requiredVersion) { | ||
return reject( | ||
new Error( | ||
`No matching jv versions: expected version ${requiredVersion} but found version ${installedVersion}`, | ||
), | ||
); | ||
} | ||
return resolve(); | ||
}); | ||
}); | ||
} | ||
|
||
function getExtensionVersion(context: ExtensionContext): string | undefined { | ||
georg-schwarz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
const packageJsonPath = path.join(context.extensionPath, 'package.json'); | ||
const packageJsonString = readFileSync(packageJsonPath, 'utf8'); | ||
const packageJson = JSON.parse(packageJsonString) as unknown; | ||
|
||
const hasVersionField = | ||
typeof packageJson === 'object' && | ||
packageJson != null && | ||
'version' in packageJson && | ||
typeof packageJson.version === 'string'; | ||
|
||
if (!hasVersionField) { | ||
return undefined; | ||
} | ||
return packageJson.version as string; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.