-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/#392_Unpack_gz_files_and_#391follow_redirects #405
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
71f22c7
Update docs to be in line with working code
rhazn 1124884
Merge pull request #382 from jvalue/update-docs-381
rhazn 3a13303
Added 'followRedirects' property to http-extractor-meta and added res…
A-M-A-X e97b0a6
changed formatting
A-M-A-X a83e6f6
initial commit. ExampleJV was only initially set up
A-M-A-X 561c088
Merge branch 'feature/391-HTTPExtractor-should-follow-redirects' into…
A-M-A-X 6149013
Added gzip decompress to archive-interpreter and fixed issue with htt…
A-M-A-X 7b963ad
added to description, format and tests
A-M-A-X a23642a
removed unused imports
A-M-A-X 1eb6e1b
Merge pull request #1 from A-M-A-X/feature/392-Unpack-gz-files
A-M-A-X b119c5e
Merge remote-tracking branch 'jvalue/jayvee/origin/dev'
A-M-A-X 5f55fb9
formatted code
A-M-A-X 8d0d124
format
A-M-A-X 9fe5645
removed jv example files
A-M-A-X 88d480a
formatted and refactored code
A-M-A-X 35aef3f
refactored to reduce repetition in code
A-M-A-X b1f1b0d
fixed error in previous commit
A-M-A-X 5194dbe
.
A-M-A-X be91eda
added missing type to variable
A-M-A-X 729788b
added pr feedback - simplified createAndPutFile to createFileFromArch…
A-M-A-X 9499a52
Removed whitespaces
A-M-A-X d705a2b
Merge remote-tracking branch 'DevTest/dev'
A-M-A-X File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very confused how this works because I can only see one
putFile
call and no loops or iterations. Does this actually correctly expand gz archives with multiple files in them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my understanding gzip is used to compress individual files. To compress multiple files with gzip, they have to be concated first, e.g to a .tar file. This I would implement in a different feature. Happy to further look into this, if you disagree.