-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Retry Mechanism for HttpExtractor #404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think our default strategy should be exponential backoffs and we should enforce some form of minimal delay. Right now it is trivial to missconfigure (or deliberately configure in the case of JV cloud) this to spam a source with 1ms delayed requests.
I'd go with exponential backoff and minimal delay of 2s. So we'd have 2, 4, 8... etc backoffs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is wrong but intuitively, I'd assume exp backoff to be 1, 2, 4... for 1000ms. Maybe we force a min value of 2000 or do the 1,2,4 by hand?
I am fine with merging it like this as well though.
Closes #403.
Example