Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting profiles #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extracting profiles #81

wants to merge 2 commits into from

Conversation

mvardjan
Copy link

@mvardjan mvardjan commented Oct 6, 2016

Improvements / fixes:

  1. When reading profiles from pom.xml, if the <id> element within <profile> is not in the first line after <profile> then it was not read at all. I have changed this so profile reading is more robust and <id> can be in any line within the profile element. It is still more of a workaround rather than proper parsing of XML file but it does the job.
  2. When the root pom.xml has some modules, their poms are included too. For example, profiles can be specified in a module only and they are not read if only root pom is parsed.

Mitja Vardjan added 2 commits October 7, 2016 00:58
id of a profile (the <id> element within <profile>) can be specified in any line, it does not have to be specified in the first line
@mosabua
Copy link
Collaborator

mosabua commented Apr 21, 2020

Is this still valid and up to date?

@mvardjan
Copy link
Author

Yes, the changes are still valid.
For description, please see my comment above.

Copy link

@ulfatufo ulfatufo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello would my dreams official Pakistan off world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants