Skip to content

Commit

Permalink
feat: remove grpc port (#98)
Browse files Browse the repository at this point in the history
## Description
removed grpc port

## Motivation and Context
Since grpc port is not used, this pr aims to remove it.

## Breaking Changes
grpc port removed

## How Has This Been Tested?
- [ ] I have updated at least one of the `examples/*` to demonstrate and
validate my change(s)
- [ ] I have tested and validated these changes using one or more of the
provided `examples/*` projects
<!--- Users should start with an existing example as its written, deploy
it, then check their changes against it -->
<!--- This will highlight breaking/disruptive changes. Once you have
checked, deploy your changes to verify -->
<!--- Please describe how you tested your changes -->
- [x] I have executed `pre-commit run -a` on my pull request
<!--- Please see
https://github.com/antonbabenko/pre-commit-terraform#how-to-install for
how to install -->
  • Loading branch information
pehlicd authored Apr 2, 2024
1 parent cad8e9a commit a5a77a6
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ Terraform module which creates a ecs app
| <a name="input_ordered_placement_strategy"></a> [ordered\_placement\_strategy](#input\_ordered\_placement\_strategy) | Service level strategy rules that are taken into consideration during task placement.<br>List from top to bottom in order of precedence. The maximum number of ordered\_placement\_strategy blocks is 5.<br>See [`ordered_placement_strategy`](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecs_service#ordered_placement_strategy) | <pre>list(object({<br> type = string<br> field = string<br> }))</pre> | <pre>[<br> {<br> "field": "instanceId",<br> "type": "spread"<br> }<br>]</pre> | no |
| <a name="input_organizational_unit"></a> [organizational\_unit](#input\_organizational\_unit) | Usually used to indicate the AWS organizational unit, e.g. 'prod', 'sdlc' | `string` | `null` | no |
| <a name="input_port_gateway"></a> [port\_gateway](#input\_port\_gateway) | Define the gateway port | `number` | `8088` | no |
| <a name="input_port_grpc"></a> [port\_grpc](#input\_port\_grpc) | Define the grpc port | `number` | `8081` | no |
| <a name="input_port_health"></a> [port\_health](#input\_port\_health) | Define the health port | `number` | `8090` | no |
| <a name="input_port_mappings"></a> [port\_mappings](#input\_port\_mappings) | The port mappings to configure for the container. This is a list of maps. Each map should contain "containerPort", "hostPort", and "protocol", where "protocol" is one of "tcp" or "udp". If using containers in a task with the awsvpc or host network mode, the hostPort can either be left blank or set to the same value as the containerPort | <pre>list(object({<br> containerPort = number<br> hostPort = number<br> protocol = string<br> }))</pre> | `[]` | no |
| <a name="input_port_metadata"></a> [port\_metadata](#input\_port\_metadata) | Define the metadata port | `number` | `8070` | no |
Expand Down
8 changes: 0 additions & 8 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ locals {
hostPort = 0
protocol = "tcp"
},
{
containerPort = var.port_grpc
hostPort = 0
protocol = "tcp"
},
{
containerPort = var.port_metadata
hostPort = 0
Expand All @@ -56,9 +51,6 @@ locals {
"traefik.http.routers.gateway-${module.ecs_label.id}.entrypoints" = "gateway"
"traefik.http.routers.gateway-${module.ecs_label.id}.service" = "gateway-${module.ecs_label.id}"
"traefik.http.services.gateway-${module.ecs_label.id}.loadbalancer.server.port" = 8088
"traefik.http.routers.grpc-${module.ecs_label.id}.entrypoints" = "grpc"
"traefik.http.routers.grpc-${module.ecs_label.id}.service" = "grpc-${module.ecs_label.id}"
"traefik.http.services.grpc-${module.ecs_label.id}.loadbalancer.server.port" = 8081
"traefik.http.routers.health-${module.ecs_label.id}.entrypoints" = "health"
"traefik.http.routers.health-${module.ecs_label.id}.service" = "health-${module.ecs_label.id}"
"traefik.http.services.health-${module.ecs_label.id}.loadbalancer.server.port" = 8090
Expand Down
6 changes: 0 additions & 6 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -573,12 +573,6 @@ variable "port_gateway" {
default = 8088
}

variable "port_grpc" {
type = number
description = "Define the grpc port"
default = 8081
}

variable "port_health" {
type = number
description = "Define the health port"
Expand Down

0 comments on commit a5a77a6

Please sign in to comment.