Skip to content

Commit

Permalink
fix: update monitoring module to 2.3.2 to allow individual alarm conf…
Browse files Browse the repository at this point in the history
…iguration (#116)

## Description
Updating the justtrackio/ecs-gosoline-monitoring/aws module source to
2.3.2; which changes their alarm inputs to a map of objects.

## Motivation and Context
The referred module didn't allow to adjust individual alarms, opposed to
the description. This was fixed in the release of version 2.3.2, hence
this module needs updating as well.

## How Has This Been Tested?
Tested with an instance of each kinsumer, gateway, consumer alarm.
  • Loading branch information
selm0 authored May 27, 2024
1 parent 7cd2252 commit 46cdc20
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Terraform module which creates a ecs app
| <a name="module_ecs_service_task_customized_autoscaling"></a> [ecs\_service\_task\_customized\_autoscaling](#module\_ecs\_service\_task\_customized\_autoscaling) | justtrackio/ecs-autoscaling/aws | 1.1.0 |
| <a name="module_ecs_service_task_predefined_autoscaling"></a> [ecs\_service\_task\_predefined\_autoscaling](#module\_ecs\_service\_task\_predefined\_autoscaling) | justtrackio/ecs-autoscaling/aws | 1.1.0 |
| <a name="module_ecs_service_task_schedule"></a> [ecs\_service\_task\_schedule](#module\_ecs\_service\_task\_schedule) | justtrackio/ecs-autoscaling/aws | 1.1.0 |
| <a name="module_monitoring"></a> [monitoring](#module\_monitoring) | justtrackio/ecs-gosoline-monitoring/aws | 2.3.1 |
| <a name="module_monitoring"></a> [monitoring](#module\_monitoring) | justtrackio/ecs-gosoline-monitoring/aws | 2.3.2 |
| <a name="module_sentry"></a> [sentry](#module\_sentry) | justtrackio/project/sentry | 1.3.0 |
| <a name="module_service_task"></a> [service\_task](#module\_service\_task) | justtrackio/ecs-alb-service-task/aws | 1.4.0 |
| <a name="module_ssm_label"></a> [ssm\_label](#module\_ssm\_label) | justtrackio/label/null | 0.26.0 |
Expand All @@ -62,10 +62,10 @@ Terraform module which creates a ecs app
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_additional_tag_map"></a> [additional\_tag\_map](#input\_additional\_tag\_map) | Additional key-value pairs to add to each map in `tags_as_list_of_maps`. Not added to `tags` or `id`.<br>This is for some rare cases where resources want additional configuration of tags<br>and therefore take a list of maps with tag key, value, and additional configuration. | `map(string)` | `{}` | no |
| <a name="input_alarm_consumer"></a> [alarm\_consumer](#input\_alarm\_consumer) | This can be used to override alarms for consumers. Keys are names of the consumers. | <pre>object({<br> alarm_description = optional(string)<br> datapoints_to_alarm = optional(number, 3)<br> evaluation_periods = optional(number, 3)<br> period = optional(number, 60)<br> success_rate_threshold = optional(number, 99)<br> })</pre> | `{}` | no |
| <a name="input_alarm_consumer"></a> [alarm\_consumer](#input\_alarm\_consumer) | This can be used to override alarms for consumers. Keys are names of the consumers. | <pre>map(object({<br> alarm_description = optional(string)<br> datapoints_to_alarm = optional(number, 3)<br> evaluation_periods = optional(number, 3)<br> period = optional(number, 60)<br> success_rate_threshold = optional(number, 99)<br> }))</pre> | `{}` | no |
| <a name="input_alarm_enabled"></a> [alarm\_enabled](#input\_alarm\_enabled) | Defines if alarms should be created | `bool` | `false` | no |
| <a name="input_alarm_gateway"></a> [alarm\_gateway](#input\_alarm\_gateway) | This can be used to override alarms for gateway routes. Keys are names of the gateway route. | <pre>object({<br> alarm_description = optional(string)<br> datapoints_to_alarm = optional(number, 3)<br> evaluation_periods = optional(number, 3)<br> period = optional(number, 60)<br> success_rate_threshold = optional(number, 99)<br> })</pre> | `{}` | no |
| <a name="input_alarm_kinsumer"></a> [alarm\_kinsumer](#input\_alarm\_kinsumer) | This can be used to override alarms for kinsumers. Keys are names of the kinsumers. | <pre>object({<br> alarm_description = optional(string)<br> datapoints_to_alarm = optional(number, 1)<br> evaluation_periods = optional(number, 1)<br> period = optional(number, 60)<br> threshold_seconds_behind = optional(number, 60)<br> })</pre> | `{}` | no |
| <a name="input_alarm_gateway"></a> [alarm\_gateway](#input\_alarm\_gateway) | This can be used to override alarms for gateway routes. Keys are names of the gateway route. | <pre>map(object({<br> alarm_description = optional(string)<br> datapoints_to_alarm = optional(number, 3)<br> evaluation_periods = optional(number, 3)<br> period = optional(number, 60)<br> success_rate_threshold = optional(number, 99)<br> }))</pre> | `{}` | no |
| <a name="input_alarm_kinsumer"></a> [alarm\_kinsumer](#input\_alarm\_kinsumer) | This can be used to override alarms for kinsumers. Keys are names of the kinsumers. | <pre>map(object({<br> alarm_description = optional(string)<br> datapoints_to_alarm = optional(number, 1)<br> evaluation_periods = optional(number, 1)<br> period = optional(number, 60)<br> threshold_seconds_behind = optional(number, 3600)<br> }))</pre> | `{}` | no |
| <a name="input_alarm_scheduled"></a> [alarm\_scheduled](#input\_alarm\_scheduled) | This can be used to override scheduled alarm | <pre>object({<br> alarm_description = optional(string)<br> datapoints_to_alarm = optional(number, 1)<br> evaluation_periods = optional(number, 1)<br> period = optional(number, 60)<br> threshold = optional(number, 0)<br> })</pre> | `{}` | no |
| <a name="input_alarm_service_resources_cpu_average"></a> [alarm\_service\_resources\_cpu\_average](#input\_alarm\_service\_resources\_cpu\_average) | Average CPUUtilization alarm specs | <pre>object({<br> datapoints_to_alarm = optional(number, 6)<br> evaluation_periods = optional(number, 6)<br> period = optional(number, 300)<br> threshold = optional(number, 125)<br> })</pre> | <pre>{<br> "datapoints_to_alarm": 6,<br> "evaluation_periods": 6,<br> "period": 300,<br> "threshold": 125<br>}</pre> | no |
| <a name="input_alarm_service_resources_cpu_maximum"></a> [alarm\_service\_resources\_cpu\_maximum](#input\_alarm\_service\_resources\_cpu\_maximum) | Maximum CPUUtilization alarm specs | <pre>object({<br> datapoints_to_alarm = optional(number, 15)<br> evaluation_periods = optional(number, 15)<br> period = optional(number, 60)<br> threshold = optional(number, 150)<br> })</pre> | <pre>{<br> "datapoints_to_alarm": 15,<br> "evaluation_periods": 15,<br> "period": 60,<br> "threshold": 150<br>}</pre> | no |
Expand Down
2 changes: 1 addition & 1 deletion monitoring.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ locals {
module "monitoring" {
count = var.monitoring_enabled ? 1 : 0
source = "justtrackio/ecs-gosoline-monitoring/aws"
version = "2.3.1"
version = "2.3.2"

context = module.this.context

Expand Down
14 changes: 7 additions & 7 deletions variables.tf
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
variable "alarm_consumer" {
type = object({
type = map(object({
alarm_description = optional(string)
datapoints_to_alarm = optional(number, 3)
evaluation_periods = optional(number, 3)
period = optional(number, 60)
success_rate_threshold = optional(number, 99)
})
}))
default = {}
description = "This can be used to override alarms for consumers. Keys are names of the consumers."
}
Expand All @@ -17,25 +17,25 @@ variable "alarm_enabled" {
}

variable "alarm_gateway" {
type = object({
type = map(object({
alarm_description = optional(string)
datapoints_to_alarm = optional(number, 3)
evaluation_periods = optional(number, 3)
period = optional(number, 60)
success_rate_threshold = optional(number, 99)
})
}))
default = {}
description = "This can be used to override alarms for gateway routes. Keys are names of the gateway route."
}

variable "alarm_kinsumer" {
type = object({
type = map(object({
alarm_description = optional(string)
datapoints_to_alarm = optional(number, 1)
evaluation_periods = optional(number, 1)
period = optional(number, 60)
threshold_seconds_behind = optional(number, 60)
})
threshold_seconds_behind = optional(number, 3600)
}))
default = {}
description = "This can be used to override alarms for kinsumers. Keys are names of the kinsumers."
}
Expand Down

0 comments on commit 46cdc20

Please sign in to comment.