v2.3.1 / fixed issue #13

justlep · Jan 31, 2022 · 5701c11 · 5701c11
1 parent 09eb582
commit 5701c11
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "LePsControllerScripts4Bitwig",
   "title": "LeP's controller scripts for Bitwig",
   "description": "Bitwig controller script for the Behringer BCF2000, Arturia Beatstep Pro and more",
-  "version": "2.2.0",
+  "version": "2.3.1",
   "author": {
     "name": "Lennart Pegel",
     "email": "[email protected]",

diff --git a/src/lep-framework/view/SelectedTrackView.js b/src/lep-framework/view/SelectedTrackView.js
@@ -17,7 +17,8 @@ lep.SelectedTrackView = function(opts) {
     var _opts = opts || {},
         _numSends = _opts.numSends || 0,
         _numScenes = _opts.numScenes || 0,
-        _id = this.name;
+        _id = this.name,
+        self = this;
 
     lep.util.assertNumberInRange(_numSends, 0, 50, 'Invalid numSends for {}: {}', this.name, _numSends);
     lep.util.assertNumberInRange(_numScenes, 0, 50, 'Invalid numScenes for {}: {}', this.name, _numScenes);
@@ -28,20 +29,22 @@ lep.SelectedTrackView = function(opts) {
 
     var _cursorTrack = host.createCursorTrack(_id, this.name, _numSends, _numScenes, false),
         _settableIsPinned = _cursorTrack.isPinned(),
-        _syncChannel = function() {
-            _cursorTrack.selectChannel(lep.SelectedTrackView._autoFollowingCursorTrack);
-        },
-        _syncOrNOP = _syncChannel;
+        _isTrackAlreadySelected = false;
 
+    _cursorTrack.addIsSelectedInEditorObserver(function(isSelected) {
+        _isTrackAlreadySelected = isSelected;
+    });
+
     lep.SelectedTrackView._autoFollowingCursorTrack.name().addValueObserver(function(trackName) {
         // lep.logWarn('Track of {} is now {}', self.name, trackName);
-        _syncOrNOP();
-    });
-
+        if (trackName && !_isTrackAlreadySelected && !self.locked()) {
+            _cursorTrack.selectChannel(lep.SelectedTrackView._autoFollowingCursorTrack);
+        }
+    });    
+
     this.locked = ko.computed({
         read: ko.observable(false).updatedByBitwigValue(_settableIsPinned),
         write: function(doLock) {
-            _syncOrNOP = doLock ? lep.util.NOP : _syncChannel;
             _settableIsPinned.set(!!doLock);
         }
     }).extend({toggleable: true});
@@ -69,4 +72,4 @@ lep.SelectedTrackView._autoFollowingCursorTrack = null;
  * @type {lep.SelectedTrackView[]}
  * @private
  */
-lep.SelectedTrackView._instances = [];
+lep.SelectedTrackView._instances = [];
diff --git a/stable-version-for-download/LeP's Controller Scripts v2.3.1.zip b/stable-version-for-download/LeP's Controller Scripts v2.3.1.zip
diff --git a/stable-version-for-download/history.txt b/stable-version-for-download/history.txt
@@ -1,4 +1,8 @@
 
+v2.3.1 (31-Jan-2022)
+ - fixed issue #13
+   (the track name field lost focus after first keystroke when renaming a track in a saved+reopened project)
+
 v2.3.0 (22-Apr-2018)
  - added Behringer X-Touch Compact
  - BCF2000: added MultiSends mode; Params lockable to device