Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom extension for resolveFullPath and add regex for minified js #203

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

axmad386
Copy link
Contributor

@axmad386 axmad386 commented Nov 7, 2023

Hi, this library is all I need. Using it with esbuild is great combo. But I miss something

First, when the target files is minified version (esbuild minify=true), then It will not replace anything. Because minified version is look like this

import"something";
import{X}from"something";

As you can see, there is no space after import and from statement. I add regex to cover this situation, please correct me is the regex can be simplified.

Second, when using resolveFullPath option, this library only search for .js extension. My project is full esm, it's using .mjs. So I create additional option to cover this, so It can be adjusted to search .mjs or .cjs. By default it will search .js. I don't know if it's the best way.

@justkey007 justkey007 merged commit 3070c3c into justkey007:master Nov 14, 2023
1 check passed
@epicmau5time
Copy link
Contributor

Hi @justkey007. This says it was merged into master and the read me says that resolveFullExtension is available but it does not seem to be a part of the actual code. The last release shows september and this was merged in November but no release followed this merge.

https://www.npmjs.com/package/tsc-alias?activeTab=code
(/tsc-alias/dist/interfaces.d.ts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants