terraform-workspace: use TF CLI

[v0id3r]

No description provided.

[justjanne]

Could you please explain in more detail why you believe this is needed? Spawning an additional process tends to increase latency quite a bit, so we try to avoid that unless necessary

[5HT2]

The only reason I can see to do this is if c.Workspace()¹ has some kind of side-effect that does a refresh, or ensures that the current selected workspace still exists?

If that is the case, it would probably be better to implement a proper check to refresh the workspace if, say, a lock file has changed or similar, the PR itself seems kind of redundant.

func (c *WorkspaceShowCommand) Run(args []string) int {
	args = c.Meta.process(args)
	cmdFlags := c.Meta.extendedFlagSet("workspace show")
	cmdFlags.Usage = func() { c.Ui.Error(c.Help()) }
	if err := cmdFlags.Parse(args); err != nil {
		c.Ui.Error(fmt.Sprintf("Error parsing command-line flags: %s\n", err.Error()))
		return 1
	}


	workspace, err := c.Workspace()
	if err != nil {
		c.Ui.Error(fmt.Sprintf("Error selecting workspace: %s", err))
		return 1
	}
	c.Ui.Output(workspace)


	return 0
}

Footnotes

1. hashicorp/terraform/internal/command/workspace_show.go#L17-L34 ↩