Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build linux_x86_64 in manylinux2014 container #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fapdash
Copy link

@fapdash fapdash commented Sep 23, 2024

This builds the linux_x86_64 release in the manylinux2014 container to
maximize compatibility.

works on justinbarclay#14
@justinbarclay
Copy link
Owner

justinbarclay commented Oct 12, 2024

Hey @fapdash, sorry for taking so long to get back to you.

I don't want the default version of the library to be based on the manylinux variant, the trade off looks to be using outdated tech and I don't want to have to maintain that. However, I am happy to have a manylinux variant of parinfer-rust-emacs be an option to download automatically from parinfer-rust-mode.

I would like to see the manylinux version in its own workflow file and upload it with a separate name from parinfer-rust-linux.so . Maybe something like parinfer-rust-snapd-linux.so , since this is the variant we are specifically looking to address. But I trust you to pick out an appropriate name to help you find the correct version of the library when reading through docs.

After that, I would have to make parinfer-rust--lib-name customizable and then users should be able to set their config to parinfer-rust-<name>.so be able to auto-download their preferred variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants