Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pie-radio-group): DSW-2636 apply name prop to child radio buttons and update test-aperture #2167

Merged
merged 4 commits into from
Jan 23, 2025
Merged

feat(pie-radio-group): DSW-2636 apply name prop to child radio buttons and update test-aperture #2167

merged 4 commits into from
Jan 23, 2025

Conversation

jamieomaguire
Copy link
Contributor

@jamieomaguire jamieomaguire commented Jan 21, 2025 •
edited by ashleynolan
Loading

Describe your changes (can list changeset entries if preferable)

  • Ensures the name prop provided to the Radio Group component is correctly passed down to each radio button in it's slot
  • Minor update to the test-aperture command to more cleary surface errors in the Github comments

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have reviewed visual test updates properly before approving.

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @xander-marjoram

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • [-] N/AIf there are visual test updates, I have reviewed them.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3b77d83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@justeattakeaway/pie-radio-group Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamieomaguire jamieomaguire added work-in-progress This pull request is still a work in progress and may not be ready for review DO NOT MERGE and removed components pie-radio-group labels Jan 21, 2025
@jamieomaguire
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@jamieomaguire
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@jamieomaguire
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

An unexpected error occurred during the snapshot release process:

No changed packages found! Please make sure you have added a changeset entry for the packages you would like to snapshot.

@jamieomaguire
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

siggerzz
siggerzz reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@siggerzz siggerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol comment

@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@jamieomaguire jamieomaguire removed work-in-progress This pull request is still a work in progress and may not be ready for review DO NOT MERGE labels Jan 23, 2025
@jamieomaguire jamieomaguire merged commit 4303fef into main Jan 23, 2025
35 of 38 checks passed
@jamieomaguire jamieomaguire deleted the dsw-2636-name-prop branch January 23, 2025 15:38
@pie-design-system-bot pie-design-system-bot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siggerzz siggerzz siggerzz left review comments

@xander-marjoram xander-marjoram xander-marjoram approved these changes

@ashleynolan ashleynolan ashleynolan approved these changes

Assignees
No one assigned
Labels
apps components pie-monorepo-utils pie-radio-group pie-storybook tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamieomaguire @pie-design-system-bot @ashleynolan @siggerzz @xander-marjoram