Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-modal): DSW-2676 ensure the page doesn't scroll when the modal is opened #2152

Merged
merged 13 commits into from
Jan 15, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(pie-modal): DSW-2676 update story
raoufswe committed Jan 13, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit be8413d0126d66f8e076b5c9143e5f0e6413b4a4
3 changes: 2 additions & 1 deletion apps/pie-storybook/stories/pie-modal.stories.ts
Original file line number Diff line number Diff line change
@@ -273,8 +273,9 @@ const FormStoryTemplate = (props: ModalProps) => {
};

const ScrollablePageStoryTemplate = (props: ModalProps) => html`
${BaseStoryTemplate(props)}
${createScrollablePageHTML()}
${BaseStoryTemplate(props)}`;
<pie-button id="open-modal" @click=${toggleModal}>Toggle Modal</pie-button>`;

const FocusableElementsPageStoryTemplate = (props: ModalProps) => html`
${BaseStoryTemplate(props)}

Unchanged files with check annotations Beta

export default chipStoryMeta;
const clickAction = () => {
/* eslint-disable-next-line no-console */

Check warning on line 90 in apps/pie-storybook/stories/testing/pie-chip.test.stories.ts

GitHub Actions / lint-js

Unexpected console statement
console.log('pie-chip clicked');
};
const closeAction = () => {

Check warning on line 93 in apps/pie-storybook/stories/testing/pie-chip.test.stories.ts

GitHub Actions / lint-js

Unexpected console statement
/* eslint-disable-next-line no-console */
console.log('pie-chip-close clicked');
};
export default toastProviderStoryMeta;
const onQueueUpdate = (queue: CustomEvent) => {
/* eslint-disable-next-line no-console */

Check warning on line 33 in apps/pie-storybook/stories/testing/pie-toast-provider.test.stories.ts

GitHub Actions / lint-js

Unexpected console statement
console.log('toast provider queue:', queue.detail);
};
import { test, expect } from '@justeattakeaway/pie-webc-testing/src/playwright/playwright-fixtures.ts';
import { BasePage } from '@justeattakeaway/pie-webc-testing/src/helpers/page-object/base-page.ts';

Check warning on line 3 in packages/components/pie-thumbnail/test/accessibility/pie-thumbnail.spec.ts

GitHub Actions / lint-js

'PieThumbnail' is defined but never used
test.describe('PieThumbnail - Accessibility tests', () => {
test('a11y - should test the PieThumbnail component WCAG compliance', async ({ page, makeAxeBuilder }) => {
// Arrange