Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-thumbnail): DSW-2578 add pie thumbnail skeleton #2112

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

bntsv
Copy link
Contributor

@bntsv bntsv commented Dec 6, 2024

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • If changes will affect consumers of the package, I have created a changeset entry.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed visual test updates properly before approving.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A - I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2 - @xander-marjoram

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A - I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@bntsv bntsv requested review from a team as code owners December 6, 2024 12:22
Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: a104695

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@justeattakeaway/pie-thumbnail Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bntsv
Copy link
Contributor Author

bntsv commented Dec 6, 2024

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@bntsv Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@siggerzz
Copy link
Contributor

siggerzz commented Dec 6, 2024

No need to test in aperture this time around as it's just the generated files, but definitely worth doing as you continue development in future PRs!

@siggerzz
Copy link
Contributor

siggerzz commented Dec 6, 2024

@bntsv - Just noticed a bug in the generator that's causing generated test to fail. I'll commit a change (probably Monday) to fix, with a follow-up PR to fix the underlying issue in the generator

@bntsv
Copy link
Contributor Author

bntsv commented Dec 6, 2024

@bntsv - Just noticed a bug in the generator that's causing generated test to fail. I'll commit a change (probably Monday) to fix, with a follow-up PR to fix the underlying issue in the generator

Great, thank you! I was about to ask why you think the test was failing.

siggerzz
siggerzz previously approved these changes Dec 12, 2024
@xander-marjoram xander-marjoram self-requested a review December 12, 2024 09:45
@siggerzz siggerzz merged commit 55c347b into main Dec 12, 2024
53 of 54 checks passed
@siggerzz siggerzz deleted the dsw-2578-add-pie-thumbnail branch December 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants