-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-thumbnail): DSW-2578 add pie thumbnail skeleton #2112
Conversation
🦋 Changeset detectedLatest commit: a104695 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
748a3fe
to
e6b3136
Compare
/test-aperture |
Starting a new snapshot build. You can view the logs here. |
@bntsv Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
No need to test in aperture this time around as it's just the generated files, but definitely worth doing as you continue development in future PRs! |
@bntsv - Just noticed a bug in the generator that's causing generated test to fail. I'll commit a change (probably Monday) to fix, with a follow-up PR to fix the underlying issue in the generator |
Great, thank you! I was about to ask why you think the test was failing. |
e6b3136
to
fd2b2fb
Compare
4fecdc2
to
f579e97
Compare
f579e97
to
b1103d0
Compare
Describe your changes (can list changeset entries if preferable)
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook
/PIE Docs
PR preview.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
/test-aperture
command.Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/A
if not applicable.Reviewer 1 - @siggerzz
PIE Storybook
/PIE Docs
PR preview.Reviewer 2 - @xander-marjoram
PIE Storybook
/PIE Docs
PR preview.