Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-cookie-banner): WCP-000 refactorerd the locale fallback logic #2043

Merged
merged 24 commits into from
Nov 18, 2024

Conversation

oliversweb
Copy link
Member

@oliversweb oliversweb commented Nov 11, 2024

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 - @jamieomaguire

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

@oliversweb oliversweb requested review from a team as code owners November 11, 2024 09:42
Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: d3ef22b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@justeattakeaway/pie-cookie-banner Minor
pie-docs Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-pr-2043 November 12, 2024 15:27 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2043 November 12, 2024 15:28 Inactive
@oliversweb
Copy link
Member Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@oliversweb
Copy link
Member Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

@oliversweb Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@oliversweb
Copy link
Member Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@oliversweb Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

siggerzz
siggerzz previously approved these changes Nov 14, 2024
@oliversweb oliversweb added the approved-1 Approved by one team member label Nov 15, 2024
@oliversweb oliversweb added the approved-2 Approved by two team members label Nov 18, 2024
@oliversweb oliversweb merged commit 2dd4d53 into main Nov 18, 2024
29 checks passed
@oliversweb oliversweb deleted the wcp-000-added-dynamic-locale-resolver branch November 18, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants