Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pie-docs): DSW-000 exclude storybook previews from a11y testing #1661

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

xander-marjoram
Copy link
Contributor

@xander-marjoram xander-marjoram commented Jul 31, 2024

Describe your changes (can list changeset entries if preferable)

  • Exclude iframe elements from accessibility tests
  • Fix a conflict in the page ordering in the Foundations section (both Radius and Motion had order: 5)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Docs PR preview

Reviewer checklists (complete before approving)

Reviewer 1 @maledr5

  • I have reviewed the PIE Docs PR preview

Reviewer 2 - @jamieomaguire

  • I have reviewed the PIE Docs PR preview

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 3f34285

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pie-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xander-marjoram xander-marjoram marked this pull request as ready for review July 31, 2024 11:06
@xander-marjoram xander-marjoram requested review from a team as code owners July 31, 2024 11:06
@xander-marjoram xander-marjoram self-assigned this Jul 31, 2024
maledr5
maledr5 previously approved these changes Jul 31, 2024
jamieomaguire
jamieomaguire previously approved these changes Jul 31, 2024
@xander-marjoram xander-marjoram merged commit 7cda496 into main Jul 31, 2024
34 checks passed
@xander-marjoram xander-marjoram deleted the dsw-000-docs-a11y-tests branch July 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants