-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pie-checkbox): DSW-000 design review comments #1660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7655020 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dandel10n
force-pushed
the
dsw-000-design-review
branch
2 times, most recently
from
August 1, 2024 09:45
bb46f1c
to
5b541a6
Compare
dandel10n
force-pushed
the
dsw-000-design-review
branch
4 times, most recently
from
August 1, 2024 14:43
885ad5d
to
b719e4a
Compare
ashleynolan
reviewed
Aug 1, 2024
ashleynolan
reviewed
Aug 1, 2024
ashleynolan
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments
ashleynolan
reviewed
Aug 2, 2024
ashleynolan
reviewed
Aug 2, 2024
ashleynolan
reviewed
Aug 2, 2024
raoufswe
reviewed
Aug 2, 2024
raoufswe
reviewed
Aug 2, 2024
raoufswe
reviewed
Aug 2, 2024
raoufswe
reviewed
Aug 2, 2024
… css spacing update
…el slot is passed
dandel10n
force-pushed
the
dsw-000-design-review
branch
from
August 2, 2024 14:54
7b1c66b
to
fe5583b
Compare
ashleynolan
previously approved these changes
Aug 2, 2024
raoufswe
previously approved these changes
Aug 2, 2024
…assistive-text-offset css var
raoufswe
approved these changes
Aug 2, 2024
ashleynolan
approved these changes
Aug 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
"@justeattakeaway/pie-checkbox": minor
[Changed] - cursor styling for disabled state changed from default to not-allowed.
[Added] - transition styles to border colour in addition to background colour.
"@justeattakeaway/pie-checkbox-group": minor
[Changed] - replaced label prop with a slot.
[Changed] - increased spacing after label and before assistive text.
[Changed] - reduced spacing detween checkboxes in inline mode.
Author Checklist (complete before requesting a review)
PIE Storybook
PR previewReviewer checklists (complete before approving)
Reviewer 1
PIE Storybook
PR preview: https://pr1660-storybook.pie.design/Reviewer 2 @raoufswe
PIE Storybook
PR preview: https://pr1660-storybook.pie.design/