Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-checkbox): DSW-000 design review comments #1660

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

dandel10n
Copy link
Contributor

@dandel10n dandel10n commented Jul 31, 2024

Describe your changes (can list changeset entries if preferable)


"@justeattakeaway/pie-checkbox": minor

[Changed] - cursor styling for disabled state changed from default to not-allowed.
[Added] - transition styles to border colour in addition to background colour.


"@justeattakeaway/pie-checkbox-group": minor

[Changed] - replaced label prop with a slot.
[Changed] - increased spacing after label and before assistive text.
[Changed] - reduced spacing detween checkboxes in inline mode.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.

Reviewer checklists (complete before approving)

Reviewer 1

Reviewer 2 @raoufswe

@dandel10n dandel10n requested review from a team as code owners July 31, 2024 09:39
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 7655020

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@justeattakeaway/pie-checkbox Minor
@justeattakeaway/pie-checkbox-group Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dandel10n dandel10n force-pushed the dsw-000-design-review branch 2 times, most recently from bb46f1c to 5b541a6 Compare August 1, 2024 09:45
@dandel10n dandel10n force-pushed the dsw-000-design-review branch 4 times, most recently from 885ad5d to b719e4a Compare August 1, 2024 14:43
Copy link
Contributor

@ashleynolan ashleynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments

@dandel10n dandel10n requested a review from ashleynolan August 2, 2024 13:56
@dandel10n dandel10n force-pushed the dsw-000-design-review branch from 7b1c66b to fe5583b Compare August 2, 2024 14:54
ashleynolan
ashleynolan previously approved these changes Aug 2, 2024
raoufswe
raoufswe previously approved these changes Aug 2, 2024
@dandel10n dandel10n dismissed stale reviews from raoufswe and ashleynolan via 5fc4f07 August 2, 2024 15:12
@dandel10n dandel10n merged commit bde5fdf into main Aug 2, 2024
35 of 37 checks passed
@dandel10n dandel10n deleted the dsw-000-design-review branch August 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants