Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-storybook): DSW-000 upgraded to Storybook v8 #1635

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

ashleynolan
Copy link
Contributor

@ashleynolan ashleynolan commented Jul 27, 2024

Describe your changes

pie-storybook

[Changed] - Moved PIE Storybook to v1 release 🎉
[Changed] - Upgrade to Storybook v8

pie-monorepo

[Changed] - Turned on Turborepo UI

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If changes will affect consumers of the package, I have created a changeset entry.

Reviewer checklists (complete before approving)

Reviewer 1 - Fernando

  • I have reviewed the PIE Storybook PR preview

Reviewer 2

  • I have reviewed the PIE Storybook PR preview

@ashleynolan ashleynolan requested review from a team as code owners July 27, 2024 10:18
Copy link

changeset-bot bot commented Jul 27, 2024

🦋 Changeset detected

Latest commit: 47de201

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@fernandofranca fernandofranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
What does the Turborepo UI do?

@ashleynolan
Copy link
Contributor Author

@fernandofranca This video gives a good overview of the main Turborepo updates (like the UI).

It splits tasks up into an interactive split screen view, which (I find) easier to use once you get used to it. It also will allow us to create interactive tasks (like for example, you can set test tasks to run interactively so if they fail, you can re-run the test in the same task window). I haven't set this up yet, but it looks like it could be a good thing for us to do in the future too.

@ashleynolan ashleynolan merged commit dabcf2e into main Jul 30, 2024
56 of 60 checks passed
@ashleynolan ashleynolan deleted the dsw-000-storybook8 branch July 30, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants