-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-checkbox-group): DSW-1937 a11y improvements #1630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c505cb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dandel10n
force-pushed
the
dsw-1937-checkbox-group-a11y
branch
4 times, most recently
from
July 26, 2024 11:40
5952f4d
to
5dbde3a
Compare
dandel10n
force-pushed
the
dsw-1937-checkbox-group-a11y
branch
from
July 26, 2024 11:56
5dbde3a
to
397fc13
Compare
dandel10n
force-pushed
the
dsw-1937-checkbox-group-a11y
branch
from
July 26, 2024 13:26
7468d8b
to
f258fb4
Compare
jamieomaguire
previously approved these changes
Jul 26, 2024
… CheckboxProps imports
jamieomaguire
approved these changes
Jul 26, 2024
xander-marjoram
approved these changes
Jul 26, 2024
Merged
JoshuaNg2332
pushed a commit
that referenced
this pull request
Jul 29, 2024
* feat(pie-checkbox-group): DSW-1937 a11y improvements * feat(pie-checkbox-group): DSW-1937 making _slottedChildren query optional * feat(pie-checkbox-group): DSW-1937 type for SlottedComponentProps and CheckboxProps imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: shadow DOM limitation for ARIA attributes binding + fieldset with checkboxes not announcing aria-describedby element text in VoiceOver and NVDA (known bug in screenreaders)
More info: https://www.matuzo.at/blog/2023/web-components-accessibility-faq/aria-references/ and nvaccess/nvda#12718
Solution: making PIE Assistive Text component optionally visually hidden to pass error information down to each Checkbox in Checkbox Group for assistive tech to have the error info while visually error will be shown only under Checkbox Group.
No visual changes to components introduced. PIE Docs Percy test shows a new prop added to PIE Assistive Text.
Author Checklist (complete before requesting a review)
PIE Storybook
/PIE Docs
PR previewReviewer 1 - @xander-marjoram
Reviewer 2 - @jamieomaguire