Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pie-monorepo): DSW-000 Update Turborepo #1628

Merged
merged 5 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/six-adults-dance.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"pie-monorepo": minor
---

[Updated] - turbo version bump to 2.0.9
2 changes: 1 addition & 1 deletion apps/pie-docs/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"extends": [
"//"
],
"pipeline": {
"tasks": {
"clean": {
"cache": false,
"dependsOn": []
Expand Down
2 changes: 1 addition & 1 deletion apps/pie-storybook/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"extends": [
"//"
],
"pipeline": {
"tasks": {
"dev": {
"cache": false,
"dependsOn": [
Expand Down
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"engines": {
"node": "^16 || ^18 || ^20"
},
"packageManager": "[email protected]",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"workspaces": {
"packages": [
"apps/**/*",
Expand Down Expand Up @@ -52,9 +53,9 @@
"test:generate-routes": "turbo run test:generate-routes --filter=!pie-monorepo --token=${TURBO_TOKEN}",
"test:browsers-setup": "turbo run test:browsers-setup --filter=!pie-monorepo --token=${TURBO_TOKEN}",
"test:browsers": "cross-env-shell turbo run test:browsers --filter=!pie-monorepo --token=${TURBO_TOKEN}",
"test:browsers:ci": "cross-env-shell turbo run test:browsers:ci --filter=!pie-monorepo --token=${TURBO_TOKEN}",
"test:browsers:ci": "cross-env-shell turbo run test:browsers:ci --filter=!pie-monorepo --token=${TURBO_TOKEN} --env-mode=loose",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, Turborepo now only provides env variables to task that are defined in env - https://turbo.build/repo/docs/reference/configuration#env

This is because env vars should be considered as part of the cache hash. We should look to eventually update tasks to define the env vars they're dependant on, and remove this flag.

"test:visual": "turbo run test:visual --filter=!pie-monorepo",
"test:visual:ci": "turbo run test:visual:ci --filter=!pie-monorepo"
"test:visual:ci": "turbo run test:visual:ci --filter=!pie-monorepo --env-mode=loose"
},
"stylelint": {
"extends": "@justeattakeaway/stylelint-config-pie/base"
Expand Down Expand Up @@ -115,7 +116,7 @@
"stylelint-config-standard-scss": "13.0.0",
"stylelint-order": "6.0.4",
"ts-node": "10.9.1",
"turbo": "1.10.16",
"turbo": "2.0.9",
"typescript": "5.4.5",
"vite": "4.5.3",
"vite-plugin-dts": "2.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/pie-css/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"extends": [
"//"
],
"pipeline": {
"tasks": {
"build": {
"cache": true,
"inputs": ["./css/**", "./scss/**"],
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/pie-icons-react/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"extends": [
"//"
],
"pipeline": {
"tasks": {
"build:icons": {
"cache": true,
"dependsOn": [
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/pie-icons-vue/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"extends": [
"//"
],
"pipeline": {
"tasks": {
"build:icons": {
"cache": true,
"dependsOn": [
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/pie-icons-webc/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"extends": [
"//"
],
"pipeline": {
"tasks": {
"build:icons": {
"cache": true,
"dependsOn": [
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/pie-icons/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"extends": [
"//"
],
"pipeline": {
"tasks": {
"build": {
"cache": true,
"dependsOn": [
Expand Down
2 changes: 1 addition & 1 deletion turbo.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://turborepo.org/schema.json",
"pipeline": {
"tasks": {
"build": {
"cache": true,
"dependsOn": [
Expand Down
Loading
Loading