Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pie-toast): DSW-2108 add variants, icons and isStrong prop #1619

Merged
merged 51 commits into from
Aug 6, 2024
Merged

feat(pie-toast): DSW-2108 add variants, icons and isStrong prop #1619

merged 51 commits into from
Aug 6, 2024

Conversation

thejfreitas
Copy link
Member

@thejfreitas thejfreitas commented Jul 19, 2024 •
edited
Loading

Description

In this PR I am adding variants, icons and is strong prop that changes the background and icon colours.

variant
isStrong

Screenshots

Screenshot 2024-07-19 at 3 55 58 PM Screenshot 2024-07-19 at 3 55 52 PM Screenshot 2024-07-19 at 3 55 43 PM Screenshot 2024-07-19 at 3 55 36 PM Screenshot 2024-07-19 at 3 55 17 PM Screenshot 2024-07-19 at 3 55 12 PM Screenshot 2024-07-19 at 3 55 05 PM Screenshot 2024-07-19 at 3 54 57 PM Screenshot 2024-07-19 at 3 53 57 PM

═══════════════════════════════════════════════════════════

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

thejfreitas and others added 29 commits June 24, 2024 14:02
@thejfreitas
feat(pie-toast): DSW-2121 implement foundational types and template f…
d193da6 
…unctions
@thejfreitas
feat(pie-toast): DSW-2121 added storybook knobs
e22a631
@thejfreitas
feat(pie-toast): DSW-2121 implemented core markup, styles and properties
f5e365a
@thejfreitas
feat(pie-toast): DSW-2121 added unit tests
e547cc1
@thejfreitas
feat(pie-toast): DSW-2121 added visual tests
a2c7064
@thejfreitas
feat(pie-toast): DSW-2121 added changesets
9ca7fd8
@thejfreitas
feat(pie-toast): DSW-2121 update branch with latest version of main
88b370b
@thejfreitas
feat(pie-toast): DSW-2121 added stylelint disable in favor of ellipsi…
6ebe84d 
…s in multiline
@thejfreitas
feat(pie-toast): DSW-2121 updated with the latest version of main branch
85bac3a
@kevinrodrigues
Merge branch 'main' into dsw-2121-pie-toast-create-basic-markup
4554399
@kevinrodrigues
Merge branch 'main' into dsw-2121-pie-toast-create-basic-markup
297a6e4
@thejfreitas
feat(pie-toast): DSW-2121 change class name from -icon-close to -close
839fbd3
@thejfreitas
feat(pie-toast): DSW-2121 refactor close toast private method
b172efc
@thejfreitas
feat(pie-toast): DSW-2121 refactor getMessageMaxWidth for better read…
6c81c95 
…ability
@thejfreitas
feat(pie-toast): DSW-2121 refactor css classes
f200105
@thejfreitas
Merge branch 'main' into dsw-2121-pie-toast-create-basic-markup
b58739d
@thejfreitas
Merge branch 'main' into dsw-2121-pie-toast-create-basic-markup
afb62b5
@thejfreitas
Merge branch 'main' into dsw-2121-pie-toast-create-basic-markup
ae39312
@thejfreitas
feat(pie-toast): DSW-2121 refactored isMultiline custom attribute in …
c566b88 
…favor of css classes
@thejfreitas
feat(pie-toast): DSW-2108 added variant and isStrong props
097a040
@thejfreitas
feat(pie-toast): DSW-2108 added variant and isStrong props into story…
1f9b656 
…book
@thejfreitas
feat(pie-toast): DSW-2108 wip implementing variant and isStrong logic
f6c8761
@thejfreitas
feat(pie-toast): DSW-2121 remove unnecesary import
0b2c381
@thejfreitas
feat(pie-toast): DSW-2121 refactor css by removing nesting
fa2537a
@thejfreitas
feat(pie-toast): DSW-2121 removed imports
e33bdf1
@thejfreitas
feat(pie-toast): DSW-2108 update branch and solve conflicts
f706159
@thejfreitas
feat(pie-toast): DSW-2108 added styling for icons and isStrong modifiers
6a48bed
@thejfreitas
feat(pie-toast): DSW-2108 added unit tests for variants
d276dbd
@thejfreitas
feat(pie-toast): DSW-2108 added visual tests
6b22f54
@thejfreitas thejfreitas self-assigned this Jul 19, 2024
ashleynolan
ashleynolan reviewed Jul 27, 2024
View reviewed changes
packages/components/pie-toast/src/toast.scss Outdated Show resolved Hide resolved
packages/components/pie-toast/src/toast.scss Outdated Show resolved Hide resolved
packages/components/pie-toast/src/toast.scss Outdated Show resolved Hide resolved
packages/components/pie-toast/src/index.ts Outdated Show resolved Hide resolved
packages/components/pie-toast/src/index.ts Outdated Show resolved Hide resolved
@thejfreitas thejfreitas requested a review from ashleynolan July 28, 2024 16:05
ashleynolan
ashleynolan reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@ashleynolan ashleynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – couple of small things, but otherwise LGTM

@thejfreitas thejfreitas requested a review from ashleynolan August 2, 2024 19:49
@thejfreitas thejfreitas merged commit 2af0d50 into main Aug 6, 2024
40 of 42 checks passed
@thejfreitas thejfreitas deleted the dsw-2108-pie-toast-add-variants branch August 6, 2024 17:06
@pie-design-system-bot pie-design-system-bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leksaBoiko leksaBoiko leksaBoiko left review comments

@kevinrodrigues kevinrodrigues kevinrodrigues approved these changes

@ashleynolan ashleynolan ashleynolan approved these changes

@xander-marjoram xander-marjoram Awaiting requested review from xander-marjoram

Assignees

@thejfreitas thejfreitas

Labels
apps components pie-storybook pie-toast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thejfreitas @ashleynolan @kevinrodrigues @xander-marjoram @leksaBoiko