Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pie-monorepo): DSW-1969 updated pie componentsforEach replaced with for of #1607

Conversation

JoshuaNg2332
Copy link
Contributor

Describe your changes (can list changeset entries if preferable)

  • Updated pie component tests that use forEach in tests to for of

This is to help alliviate the potential issue we've noticed with variations using forEach failing to load correctly.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed visual test updates properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If there are visual test updates, I have reviewed them

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners July 16, 2024 14:40
Copy link

changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: f043e6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Lint PR Title] ❌ Failed.
The PR title should follow the same convention used for commits, e.g.:
type(scope): DSW-123 title where DSW-123 is the Jira ticket id or DSW-000 when one is not available.

@JoshuaNg2332 JoshuaNg2332 changed the title refactor(pie-monorepo): DSW-1969 forEach replaced with for of refactor(pie-monorepo): DSW-1969 updated pie componentsforEach replaced with for of Jul 16, 2024
@github-actions github-actions bot dismissed their stale review July 16, 2024 14:42

[Lint PR Title] ✅ All good!

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Jul 16, 2024


Fails
🚫 You currently have an unchecked checklist item in your PR description.

Please confirm this check has been carried out – if it's not relevant to your PR, delete this line from the PR checklist.

Generated by 🚫 dangerJS against f043e6b

@github-actions github-actions bot temporarily deployed to pie-docs-pr-1607 July 17, 2024 14:04 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1607 July 17, 2024 14:04 Inactive
@github-actions github-actions bot temporarily deployed to pie-docs-pr-1607 July 18, 2024 09:11 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1607 July 18, 2024 09:11 Inactive
@JoshuaNg2332 JoshuaNg2332 deleted the DSW-1969-percy-cli-chrome-fix-5-1 branch August 2, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants