-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pie-monorepo): DSW-1969 updated pie componentsforEach
replaced with for of
#1607
refactor(pie-monorepo): DSW-1969 updated pie componentsforEach
replaced with for of
#1607
Conversation
… percy package to lts
|
forEach
replaced with for of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Lint PR Title] ❌ Failed.
The PR title should follow the same convention used for commits, e.g.:
type(scope): DSW-123 title
where DSW-123
is the Jira ticket id or DSW-000
when one is not available.
forEach
replaced with for of
forEach
replaced with for of
Describe your changes (can list changeset entries if preferable)
forEach
in tests tofor of
This is to help alliviate the potential issue we've noticed with variations using forEach failing to load correctly.
Author Checklist (complete before requesting a review)
Reviewer checklists (complete before approving)
Reviewer 1
Reviewer 2