Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-monorepo): DSW-2056 integrate pie-webc into vue3 example app #1591

Merged
merged 3 commits into from
Jul 12, 2024
Merged

feat(pie-monorepo): DSW-2056 integrate pie-webc into vue3 example app #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eca1b30
feat(pie-monorepo): DSW-2056 integrate pie-webc into vue3 example app
kevinrodrigues Jul 11, 2024
b8924f5
feat(pie-monorepo): DSW-2056 adds pie-css back in to package file
kevinrodrigues Jul 11, 2024
0ebf772
feat(pie-monorepo): DSW-2056 resolve conflicts
kevinrodrigues Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-months-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wc-vue3": minor
---

[Added] pie-webc package and removed component level packages
7 changes: 6 additions & 1 deletion apps/examples/wc-vue3/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ module.exports = {
'plugin:vue/vue3-recommended'
],
rules: {
...vue.rules, ...vue3.rules, 'vue/sort-keys': 'off',
...vue.rules,
...vue3.rules,
'vue/sort-keys': 'off',
'import/extensions': ['error', 'ignorePackages', {
js: 'always',
}],
},
};
2 changes: 1 addition & 1 deletion apps/examples/wc-vue3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"type-check": "vue-tsc --noEmit"
},
"dependencies": {
"@justeattakeaway/pie-button": "0.47.8",
"@justeattakeaway/pie-css": "0.12.1",
"@justeattakeaway/pie-webc": "0.5.12",
"@vitejs/plugin-vue": "4.0.0",
"vite": "4.5.3",
"vue": "3.2.47"
Expand Down
2 changes: 1 addition & 1 deletion apps/examples/wc-vue3/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</template>

<script>
import { variants, sizes } from '@justeattakeaway/pie-button';
import { variants, sizes } from '@justeattakeaway/pie-webc/components/button.js';

export default {
data () {
Expand Down
Loading
Loading