feat(pie-button): DSW-000 Changing styles to use classmap #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f93ef1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ashleynolan
force-pushed
the
dsw-000-classpoc
branch
from
97492bd to
fe1f656
Compare
xander-marjoram
previously approved these changes
Jul 17, 2024
ashleynolan
force-pushed
the
dsw-000-classpoc
branch
2 times, most recently
from
f7dbb7c to
97dbd22
Compare
ashleynolan
force-pushed
the
dsw-000-classpoc
branch
from
97dbd22 to
3cc22ad
Compare
11 tasks
dandel10n
reviewed
Jul 23, 2024
ashleynolan
force-pushed
the
dsw-000-classpoc
branch
from
e9db916 to
fba1982
Compare
ashleynolan
force-pushed
the
dsw-000-classpoc
branch
from
fba1982 to
f93ef1a
Compare
jamieomaguire
approved these changes
Jul 24, 2024
xander-marjoram
approved these changes
Jul 24, 2024
Merged
JoshuaNg2332
pushed a commit
that referenced
this pull request
Jul 25, 2024
* refactor(pie-button): DSW-000 updated styles to use classmap * format(pie-button): DSW-000 formatting updates for PR comments * fix(pie-button): DSW-000 change loading attribute to class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
xsmallorsmallsize and responsive mode is true, where the bg-color wasn't updating to orange as requiredAuthor Checklist (complete before requesting a review)
PIE StorybookPR previewReviewer checklists (complete before approving)
Reviewer 1 - @xander-marjoram
PIE StorybookPR previewReviewer 2
PIE StorybookPR preview