fix(pie-cookie-banner): DSW-2184 cookie banner locale da #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4daaf7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
raoufswe
previously approved these changes
Jul 9, 2024
|
/snapit |
|
Starting a new snapshot build. You can view the logs here. |
|
@kevinrodrigues Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfileyarn up @justeattakeaway/[email protected] --mode=update-lockfileThen finally: yarn install |
oliversweb
approved these changes
Jul 10, 2024
leksaBoiko
approved these changes
Jul 10, 2024
xander-marjoram
approved these changes
Jul 10, 2024
Merged
JoshuaNg2332
pushed a commit
that referenced
this pull request
Jul 11, 2024
* fix(pie-cookie-banner): DSW-2184 fixes da mapping in translation file and fr translation change * fix(pie-cookie-banner): DSW-2184 added link translation fix * fix(pie-cookie-banner): DSW-2184 adds en-fr and corrects translations in fr-fr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a fix for FR translations which is part of the core teams requests.
═══════════════════════════════════════════════════════════
Describe your changes (can list changeset entries if preferable)
Author Checklist (complete before requesting a review)
PIE Storybook/PIE DocsPR previewReviewer checklists (complete before approving)
Reviewer 1 @raoufswe
PIE Storybook/PIE DocsPR previewReviewer 2 @oliversweb
PIE Storybook/PIE DocsPR preview