Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-docs): DSW-2100 add haptic-feedback page to Patterns #1573

Merged
merged 10 commits into from
Jul 11, 2024

Conversation

leksaBoiko
Copy link
Contributor

@leksaBoiko leksaBoiko commented Jul 3, 2024

Describe your changes (can list changeset entries if preferable)

[Added] - Haptic feedback page to Patterns

FYI:

  • Overview page: notification “Add the quarterly haptic feedback reviews to your calendar.” should be removed
  • Overview page: the description under the main image can be removed as long as we have the alt-text
  • Guidance page: firstly, we were going to have videos but we decided it is too much work to replicate the videos that are already provided in Apple, so we can remove this section "Click the play button ...."
  • Overview page: "Quarterly haptic feedback reviews" section should be removed

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.

Reviewer checklists (complete before approving)

Reviewer 1 - Maleh Duenas

  • I have reviewed the PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 @kevinrodrigues

  • I have reviewed the PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 2d97914

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pie-docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@leksaBoiko leksaBoiko changed the title feat(pie-docs): DSW-2100 add overview page and assets feat(pie-docs): DSW-2100 add haptic-feedback page to Patterns Jul 3, 2024
@leksaBoiko leksaBoiko self-assigned this Jul 3, 2024
@leksaBoiko leksaBoiko marked this pull request as ready for review July 5, 2024 08:05
@leksaBoiko leksaBoiko requested review from a team as code owners July 5, 2024 08:05
@maledr5 maledr5 self-requested a review July 8, 2024 09:16
@leksaBoiko leksaBoiko requested a review from maledr5 July 8, 2024 16:14
maledr5
maledr5 previously approved these changes Jul 9, 2024
kevinrodrigues
kevinrodrigues previously approved these changes Jul 9, 2024
Copy link

@RLumleyJET RLumleyJET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-09 at 1 23 00 PM
Below the last anchor link there is an additional 12px in addition to the 64px before the divider.

Co-authored-by: Xander Marjoram <[email protected]>
Copy link
Contributor

@xander-marjoram xander-marjoram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to take the alt text to the accessibility guild as @maledr5 suggests

@leksaBoiko leksaBoiko requested a review from maledr5 July 10, 2024 11:10
maledr5
maledr5 previously approved these changes Jul 10, 2024
@leksaBoiko
Copy link
Contributor Author

leksaBoiko commented Jul 10, 2024

@maledr5 @xander-marjoram suggestion from accessibility guild:

Soft: An illustration that represents a single haptic pulse of a specific duration and strength by showing a bar of a specific size. This particular pattern represents a soft impact.

Medium: An illustration that represents a single haptic pulse of a specific duration and strength by showing a bar of a specific size. This particular pattern represents a medium impact.

Success: An illustration that represents a series of two haptic pulses of various durations and strengths by showing bars of different sizes. This particular pattern represents a success.

Warning: An illustration that represents a series of two haptic pulses of various durations and strengths by showing bars of different sizes. This particular pattern represents a warning.

Error: An illustration that represents a series of four haptic pulses of various durations and strengths by showing bars of different sizes. This particular pattern represents an error.

@leksaBoiko leksaBoiko dismissed stale reviews from xander-marjoram and maledr5 via 749f5bd July 10, 2024 13:02
@leksaBoiko leksaBoiko merged commit 23522e2 into main Jul 11, 2024
34 checks passed
@leksaBoiko leksaBoiko deleted the dsw-2100-haptic-feedback branch July 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants